[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/base/konq-plugins/validators
From:       Pino Toscano <pino () kde ! org>
Date:       2009-01-01 2:09:57
Message-ID: 1230775797.177879.26875.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 903987 by pino:

- factor out the tree item creation for reports in an own function
- avoid creating icons and status texts at each iteration, just do it once


 M  +26 -24    reportdialog.cpp  


--- trunk/extragear/base/konq-plugins/validators/reportdialog.cpp #903986:903987
@@ -42,6 +42,20 @@
   return val1 < val2;
 }
 
+QTreeWidgetItem* createItemFromReport(const TidyReport &report, const QIcon &icon, \
const QString &iconToolTip, +                                      const QString \
&frameName, int frameNumber) +{
+  QTreeWidgetItem *item = new QTreeWidgetItem();
+  item->setIcon(0, icon);
+  item->setText(1, frameName);
+  item->setText(2, QString::number(report.line));
+  item->setText(3, QString::number(report.col));
+  item->setText(4, report.msg);
+  item->setToolTip(0, iconToolTip);
+  item->setData(0, FrameNumberRole, frameNumber);
+  return item;
+}
+
 ReportDialog::ReportDialog(const QList<ValidationResult *> &results, QWidget* \
parent)  : KDialog(parent)
 {
@@ -59,40 +73,28 @@
   int i = 0;
   Q_FOREACH (ValidationResult* res, results)
   {
+    const KIcon errorIcon("dialog-error");
+    const QString errorStatus = i18nc("Validation status", "Error");
     Q_FOREACH (const TidyReport &r, res->errors)
     {
-      QTreeWidgetItem *item = new QTreeWidgetItem();
-      item->setIcon(0, KIcon("dialog-error"));
-      item->setText(1, res->frameName);
-      item->setText(2, QString::number(r.line));
-      item->setText(3, QString::number(r.col));
-      item->setText(4, r.msg);
-      item->setToolTip(0, i18nc("Validation status", "Error"));
-      item->setData(0, FrameNumberRole, i);
+      QTreeWidgetItem *item = createItemFromReport(
+              r, errorIcon, errorStatus, res->frameName, i);
       items.append(item);
     }
+    const KIcon warningIcon("dialog-warning");
+    const QString warningStatus = i18nc("Validation status", "Warning");
     Q_FOREACH (const TidyReport &r, res->warnings)
     {
-      QTreeWidgetItem *item = new QTreeWidgetItem();
-      item->setIcon(0, KIcon("dialog-warning"));
-      item->setText(1, res->frameName);
-      item->setText(2, QString::number(r.line));
-      item->setText(3, QString::number(r.col));
-      item->setText(4, r.msg);
-      item->setToolTip(0, i18nc("Validation status", "Warning"));
-      item->setData(0, FrameNumberRole, i);
+      QTreeWidgetItem *item = createItemFromReport(
+              r, warningIcon, warningStatus, res->frameName, i);
       items.append(item);
     }
+    const KIcon a11yWarningIcon("preferences-desktop-accessibility");
+    const QString a11yWarningStatus = i18nc("Validation status", "Accessibility \
warning");  Q_FOREACH (const TidyReport &r, res->accesswarns)
     {
-      QTreeWidgetItem *item = new QTreeWidgetItem();
-      item->setIcon(0, KIcon("preferences-desktop-accessibility"));
-      item->setText(1, res->frameName);
-      item->setText(2, QString::number(r.line));
-      item->setText(3, QString::number(r.col));
-      item->setText(4, r.msg);
-      item->setToolTip(0, i18nc("Validation status", "Accessibility warning"));
-      item->setData(0, FrameNumberRole, i);
+      QTreeWidgetItem *item = createItemFromReport(
+              r, a11yWarningIcon, a11yWarningStatus, res->frameName, i);
       items.append(item);
     }
     ++i;


[prev in list] [next in list] [prev in thread] [next in thread]