[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/~ervin/zanshin
From:       Kevin Ottens <ervin () kde ! org>
Date:       2008-12-31 15:31:01
Message-ID: 1230737461.093879.20205.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 903879 by ervin:

Let's get the parameters and variable naming right.


 M  +5 -5      todoflatmodel.cpp  
 M  +1 -1      todoflatmodel.h  


--- branches/work/~ervin/zanshin/todoflatmodel.cpp #903878:903879
@@ -399,14 +399,14 @@
     }
 }
 
-bool TodoFlatModel::isAncestorOf(const QString &child, const QString &parent)
+bool TodoFlatModel::isAncestorOf(const QString &ancestor, const QString &child)
 {
-    QString p = m_parentMap[parent];
-    if (p.isEmpty())
+    QString parent = m_parentMap[child];
+    if (parent.isEmpty())
         return false;
-    if (p == child)
+    if (parent == ancestor)
         return true;
-    return isAncestorOf(child, p);
+    return isAncestorOf(ancestor, parent);
 }
 
 TodoFlatModel::TodoType TodoFlatModel::todoType(const QString &remoteId) const
--- branches/work/~ervin/zanshin/todoflatmodel.h #903878:903879
@@ -81,7 +81,7 @@
     Akonadi::ItemModel *itemModel() const;
 
     TodoType todoType(const QString &remoteId) const;
-    bool isAncestorOf(const QString &child, const QString &parent);
+    bool isAncestorOf(const QString &ancestor, const QString &child);
 
     QHash<QString, QString> m_parentMap;
     QHash<QString, QStringList> m_childrenMap;
[prev in list] [next in list] [prev in thread] [next in thread]