[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/plasma/shells/screensaver
From:       Chani Armitage <chanika () gmail ! com>
Date:       2008-12-28 22:50:08
Message-ID: 1230504608.340767.1045.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 902677 by chani:

we don't need to set the wallpaper option on every frigging draw.
in fact, since we're on the screensaver we can assume that composite will not be \
going on or off while we're running at all.


 M  +0 -8      saverview.cpp  


--- trunk/KDE/kdebase/workspace/plasma/shells/screensaver/saverview.cpp \
#902676:902677 @@ -54,14 +54,8 @@
     //QDesktopWidget *desktop = QApplication::desktop();
     //setGeometry(desktop->screenGeometry(containment->screen()));
 
-    //TODO the ctmt should only offer wallpaper to the user if there's no composite
-    //and we'll be waiting on pluggable backgrounds even for that.
     setWallpaperEnabled(!PlasmaApp::hasComposite());
 
-    //TODO 'always show widgets' option will change this.
-    //also, need a way to be sure the screensaver's shown if we're going byebye
-    //connect(scene(), SIGNAL(releaseVisualFocus()), SLOT(hideView()));
-
     installEventFilter(this);
 }
 
@@ -89,12 +83,10 @@
 void SaverView::drawBackground(QPainter * painter, const QRectF & rect)
 {
     if (PlasmaApp::hasComposite()) {
-        setWallpaperEnabled(false);
         painter->setCompositionMode(QPainter::CompositionMode_Source);
         painter->fillRect(rect, QColor(0, 0, 0, 0));
         //FIXME kwin's shadow effect is getting drawn behind me. do not want.
     } else {
-        setWallpaperEnabled(true);
         Plasma::View::drawBackground(painter, rect);
     }
 }


[prev in list] [next in list] [prev in thread] [next in thread]