[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeedu/marble/src/lib
From:       Eckhart Wörner <ew () ewsoftware ! de>
Date:       2008-12-24 16:14:06
Message-ID: 1230135246.965229.17157.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 901197 by ewoerner:

krazy: Check for foreach loop issues (2 issues)
Make MarblePlacemarkModell::removePlaceMarks parameter const


 M  +2 -2      MarbleModel.cpp  
 M  +1 -1      MarblePlacemarkModel.cpp  
 M  +1 -1      MarblePlacemarkModel.h  


--- trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp #901196:901197
@@ -409,13 +409,13 @@
         }
     }
     // unload old standard Placemarks which are not part of the new map
-    foreach(QString container, loadedContainers) {
+    foreach(const QString& container, loadedContainers) {
         loadedContainers.pop_front();
         qDebug() << "removing container:" << container << (loadList.isEmpty() && \
                loadedContainers.isEmpty());
         d->m_placemarkmanager->model()->removePlaceMarks( container, \
loadedContainers.isEmpty() );  }
     // load new standard Placemarks
-    foreach(QString container, loadList) {
+    foreach(const QString& container, loadList) {
         loadList.pop_front();
         d->m_placemarkmanager->addPlaceMarkFile( container, loadList.isEmpty() );
     }
--- trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.cpp #901196:901197
@@ -242,7 +242,7 @@
     }
 }
 
-void  MarblePlacemarkModel::removePlaceMarks( QString &containerName,
+void  MarblePlacemarkModel::removePlaceMarks( const QString &containerName,
                                               bool finalize )
 {
     if( d->m_containerMap.contains( containerName ) ) {
--- trunk/KDE/kdeedu/marble/src/lib/MarblePlacemarkModel.h #901196:901197
@@ -116,7 +116,7 @@
      *
      * Note: The model takes ownership of the place marks!
      */
-    void removePlaceMarks( QString &containerName,
+    void removePlaceMarks( const QString &containerName,
                            bool finalize = true );
 
     /**


[prev in list] [next in list] [prev in thread] [next in thread]