[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/meta/file
From:       "Dan Meltzer" <parallelgrapefruit () gmail ! com>
Date:       2008-12-22 15:30:57
Message-ID: 46059ce10812220730v759db064p6a06a202dc071f2f () mail ! gmail ! com
[Download RAW message or body]

On Mon, Dec 22, 2008 at 8:09 AM, Mark Kretschmann <kretschmann@kde.org> wrote:
> SVN commit 900181 by markey:
>
> Add debug to isEditable() for MetaFile. Let's see if that works right.

I fixed this for sqltrack.. must have missed it here.

Should use QFile(blah)->isWritable() instead, as this doesn't check
group write/allwrite.
>
>  M  +7 -2      File.cpp
>
>
> --- trunk/extragear/multimedia/amarok/src/meta/file/File.cpp #900180:900181
> @@ -157,8 +157,13 @@
>  bool
>  Track::isEditable() const
>  {
> -    //not this probably needs more work on *nix
> -    return QFile::permissions( d->url.path() ) & QFile::WriteUser;
> +    DEBUG_BLOCK
> +
> +    //note this probably needs more work on *nix
> +    const bool editable = QFile::permissions( d->url.path() ) & QFile::WriteUser;
> +
> +    debug() << d->url.path() << " editable: " << editable;
> +    return editable;
>  }
>
>  Meta::AlbumPtr
>
[prev in list] [next in list] [prev in thread] [next in thread]