[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/kdialog
From:       Urs Wolfer <uwolfer () kde ! org>
Date:       2008-12-13 13:33:07
Message-ID: 200812131433.09011.uwolfer () kde ! org
[Download RAW message or body]


On Tuesday 09 December 2008 17:44:56 Carlo Segato wrote:
> SVN commit 894929 by segato:
>
> revert r894687 KFileDialog isn't a subclass of QFileDialog so
> getExistingDirectory is a bit different
>
>  M  +6 -6      kdialog.cpp
>
>
> --- trunk/KDE/kdebase/apps/kdialog/kdialog.cpp #894928:894929
> @@ -41,9 +41,9 @@
>  #include <netwm.h>
>  #endif
>
> -// #ifdef Q_WS_WIN
> -// #include <QtGui/QFileDialog>
> -// #endif
> +#ifdef Q_WS_WIN
> +#include <QtGui/QFileDialog>
> +#endif
>  #include <unistd.h>
>
>  using namespace std;
> @@ -487,9 +487,9 @@
>          startDir = args->getOption("getexistingdirectory");
>  	QString result;
>  #ifdef Q_WS_WIN
> -	result = KFileDialog::getExistingDirectory( 0, title, startDir,
> -	                                           
> KFileDialog::DontResolveSymlinks | -	                                      
>      KFileDialog::ShowDirsOnly); +	result =
> QFileDialog::getExistingDirectory( 0, title, startDir,
> +	                                           
> QFileDialog::DontResolveSymlinks | +	                                      
>      QFileDialog::ShowDirsOnly); #else
>  	KUrl url;
>  	KDirSelectDialog myDialog( startDir, true, 0 );

Why not just remove all the win specific code? I think the default 
implementation should work now on win now as well.

Bye
urs

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]