[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/plasma
From:       "=?ISO-8859-1?Q?Alexis_M=E9nard?=" <menard () kde ! org>
Date:       2008-11-27 15:29:12
Message-ID: 81941aea0811270729h3f2e997foe0f3f084a81cf4b1 () mail ! gmail ! com
[Download RAW message or body]

yes could be more readeable.

On Thu, Nov 27, 2008 at 4:22 PM, Laurent Montel <montel@kde.org> wrote:

> On Thursday 27 November 2008 15:52:08 Alexis Ménard wrote:
> > SVN commit 889759 by menard:
> >
> > Don't try to create a nice shadow on a text if the text is empty (avoid
> > some warnings)
> >
> > Rev by aseigo
> >
> >  M  +4 -0      paintutils.cpp
> >
> >
> > --- trunk/KDE/kdelibs/plasma/paintutils.cpp #889758:889759
> > @@ -49,6 +49,10 @@
> >
> >  QPixmap shadowText(QString text, QColor textColor, QColor shadowColor,
> > QPoint offset, int radius) {
> > +    //don't try to paint stuff on a future null pixmap because the text
> is
> > empty +    if (text.size() == 0) {
>
> text.isEmpty() ?
>
> Regards
>
>
> > +        return QPixmap();
> > +    }
> >      // Draw text
> >      QFontMetrics fm(text);
> >      QRect textRect = fm.boundingRect(text);
> --
> Laurent Montel,
> KDE/KOffice developer, Qt consultancy projects
> Klarälvdalens Datakonsult AB, Platform-independent software solutions
>

[Attachment #3 (text/html)]

yes could be more readeable.<br><br><div class="gmail_quote">On Thu, Nov 27, 2008 at \
4:22 PM, Laurent Montel <span dir="ltr">&lt;<a \
href="mailto:montel@kde.org">montel@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">On Thursday 27 November 2008 \
15:52:08 Alexis Ménard wrote:<br> &gt; SVN commit 889759 by menard:<br>
&gt;<br>
&gt; Don&#39;t try to create a nice shadow on a text if the text is empty (avoid<br>
&gt; some warnings)<br>
&gt;<br>
&gt; Rev by aseigo<br>
&gt;<br>
&gt; &nbsp;M &nbsp;+4 -0 &nbsp; &nbsp; &nbsp;paintutils.cpp<br>
&gt;<br>
&gt;<br>
&gt; --- trunk/KDE/kdelibs/plasma/paintutils.cpp #889758:889759<br>
&gt; @@ -49,6 +49,10 @@<br>
&gt;<br>
&gt; &nbsp;QPixmap shadowText(QString text, QColor textColor, QColor shadowColor,<br>
&gt; QPoint offset, int radius) {<br>
&gt; + &nbsp; &nbsp;//don&#39;t try to paint stuff on a future null pixmap because \
the text is<br> &gt; empty + &nbsp; &nbsp;if (text.size() == 0) {<br>
<br>
</div>text.isEmpty() ?<br>
<br>
Regards<br>
<div><div></div><div class="Wj3C7c"><br>
<br>
&gt; + &nbsp; &nbsp; &nbsp; &nbsp;return QPixmap();<br>
&gt; + &nbsp; &nbsp;}<br>
&gt; &nbsp; &nbsp; &nbsp;// Draw text<br>
&gt; &nbsp; &nbsp; &nbsp;QFontMetrics fm(text);<br>
&gt; &nbsp; &nbsp; &nbsp;QRect textRect = fm.boundingRect(text);<br>
</div></div><font color="#888888">--<br>
Laurent Montel,<br>
KDE/KOffice developer, Qt consultancy projects<br>
Klarälvdalens Datakonsult AB, Platform-independent software solutions<br>
</font></blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]