[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevelop/plugins
From:       Laurent Montel <montel () kde ! org>
Date:       2008-11-27 8:25:38
Message-ID: 1227774338.493612.32681.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 889569 by mlaurent:

Const'ify


 M  +2 -2      appwizard/appwizardplugin.cpp  
 M  +4 -4      appwizard/projecttemplatesmodel.cpp  
 M  +3 -3      builders/makebuilder/makejob.cpp  
 M  +4 -4      coverage/coverageplugin.cpp  
 M  +1 -1      coverage/lcovinfoparser.cpp  
 M  +2 -2      grepview/grepoutputmodel.cpp  
 M  +1 -1      languages/cpp/missingincludecompletionitem.cpp  


--- trunk/KDE/kdevelop/plugins/appwizard/appwizardplugin.cpp #889568:889569
@@ -331,7 +331,7 @@
 bool AppWizardPlugin::unpackArchive(const KArchiveDirectory *dir, const QString \
&dest)  {
     kDebug() << "unpacking dir:" << dir->name() << "to" << dest;
-    QStringList entries = dir->entries();
+    const QStringList entries = dir->entries();
     kDebug() << "entries:" << entries.join(",");
 
     //This extra tempdir is needed just for the files files have special names,
@@ -344,7 +344,7 @@
 
     bool ret = true;
 
-    foreach (QString entry, entries)
+    foreach (const QString& entry, entries)
     {
         if (entry.endsWith(".kdevtemplate"))
             continue;
--- trunk/KDE/kdevelop/plugins/appwizard/projecttemplatesmodel.cpp #889568:889569
@@ -39,8 +39,8 @@
     extractTemplateDescriptions();
 
     KStandardDirs *dirs = m_plugin->componentData().dirs();
-    QStringList templateDescriptions = \
                dirs->findAllResources("apptemplate_descriptions");
-    foreach (QString templateDescription, templateDescriptions)
+    const QStringList templateDescriptions = \
dirs->findAllResources("apptemplate_descriptions"); +    foreach (const QString \
&templateDescription, templateDescriptions)  {
         KConfig templateConfig(templateDescription);
         KConfigGroup general(&templateConfig, "General");
@@ -59,7 +59,7 @@
 
     QStandardItem *parent = invisibleRootItem();
     QStringList currentPath;
-    foreach (QString entry, path)
+    foreach (const QString& entry, path)
     {
         currentPath << entry;
         if (!m_templateItems.contains(currentPath.join("/")))
@@ -85,7 +85,7 @@
 
     QString localDescriptionsDir = dirs->saveLocation("apptemplate_descriptions");
 
-    foreach (QString archName, templateArchives)
+    foreach (const QString &archName, templateArchives)
     {
         kDebug(9010) << "processing template" << archName;
 #ifdef Q_WS_WIN
--- trunk/KDE/kdevelop/plugins/builders/makebuilder/makejob.cpp #889568:889569
@@ -197,7 +197,7 @@
     QString extraOptions = builderGroup.readEntry("Additional Options", QString());
     if( ! extraOptions.isEmpty() )
     {
-        foreach(const QString option, KShell::splitArgs( extraOptions ) )
+        foreach(const QString& option, KShell::splitArgs( extraOptions ) )
             cmdline << option;
     }
 
@@ -232,9 +232,9 @@
     QString defaultProfile = builderGroup.readEntry(
             "Default Make Environment Profile", "default" );
 
-    QStringList procDefaultList = QProcess::systemEnvironment();
+    const QStringList procDefaultList = QProcess::systemEnvironment();
     QMap<QString, QString> retMap;
-    foreach( QString _line, procDefaultList )
+    foreach( const QString &_line, procDefaultList )
     {
         QString varName = _line.section( '=', 0, 0 );
         QString varValue = _line.section( '=', 1 );
--- trunk/KDE/kdevelop/plugins/coverage/coverageplugin.cpp #889568:889569
@@ -114,8 +114,8 @@
     QFileInfoList gcdaFiles;
     QDir current(dir);
     current.setFilter(QDir::Dirs | QDir::NoDotAndDotDot | QDir::Readable | \
                QDir::Writable);
-    QStringList subDirs = current.entryList();
-    foreach(QString subDir, subDirs) {
+    const QStringList subDirs = current.entryList();
+    foreach(const QString& subDir, subDirs) {
         current.cd(subDir);
         gcdaFiles += findGcdaFilesIn(current);
         current.cdUp();
@@ -130,8 +130,8 @@
 {
     if (m_buildRoot.isEmpty()) return;
     QDir root(m_buildRoot.path());
-    QFileInfoList gcdaFiles = findGcdaFilesIn(root);
-    foreach(QFileInfo f, gcdaFiles) {
+    const QFileInfoList gcdaFiles = findGcdaFilesIn(root);
+    foreach(const QFileInfo& f, gcdaFiles) {
         kDebug() << "Removing " << f.absoluteFilePath();
         QFile::remove(f.absoluteFilePath());
     }
--- trunk/KDE/kdevelop/plugins/coverage/lcovinfoparser.cpp #889568:889569
@@ -60,7 +60,7 @@
 
 void LcovInfoParser::parseLines(const QStringList& lines)
 {
-    foreach(QString l, lines) parseLine(l);
+    foreach(const QString& l, lines) parseLine(l);
 }
 
 void LcovInfoParser::parseLine(const QString& line)
--- trunk/KDE/kdevelop/plugins/grepview/grepoutputmodel.cpp #889568:889569
@@ -144,7 +144,7 @@
 
 void GrepOutputModel::appendOutputs( const QStringList &lines )
 {
-    foreach( QString line, lines )
+    foreach( const QString& line, lines )
     {
         int pos;
         QString filename, linenumber, rest;
@@ -185,7 +185,7 @@
 
 void GrepOutputModel::appendErrors( const QStringList &lines )
 {
-    foreach( QString line, lines )
+    foreach( const QString& line, lines )
         appendRow( new QStandardItem(line) );
 }
 
--- trunk/KDE/kdevelop/plugins/languages/cpp/missingincludecompletionitem.cpp \
#889568:889569 @@ -50,7 +50,7 @@
   //We have found a potential declaration. Now find the shortest include path.
   QString shortestDirective;
   bool isRelativeToCurrentDir = false;
-  foreach(KUrl includePath, includePaths) {
+  foreach(const KUrl& includePath, includePaths) {
     QString relative = KUrl::relativePath( \
QFileInfo(includePath.path()).canonicalFilePath(), \
QFileInfo(file).canonicalFilePath() );  
     if(shortestDirective.isEmpty() || (relative.length() < \
shortestDirective.length() && (allowDotDot || !relative.startsWith("..")))) {


[prev in list] [next in list] [prev in thread] [next in thread]