[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui
From:       André_Wöbbeking <Woebbeking () kde ! org>
Date:       2008-11-23 21:26:17
Message-ID: 200811232226.18412.Woebbeking () kde ! org
[Download RAW message or body]

On Sunday 23 November 2008, Michael Jansen wrote:
> SVN commit 888107 by mjansen:
>
> Add unit tests for KActionCategory and fix a bug found while writing
> them
>
> :-).
>
>  M  +10 -6     actions/kactioncategory.cpp
>  M  +1 -0      tests/CMakeLists.txt
>  A             tests/kactioncategorytest.cpp   [License: UNKNOWN]
>  A             tests/kactioncategorytest.h   [License: UNKNOWN]
>
>
> --- trunk/KDE/kdelibs/kdeui/actions/kactioncategory.cpp
> @@ -105,14 +105,18 @@
>          const char *member)
>      {
>      KAction *action = collection()->addAction(name, receiver,
> member); -    d->actions.append(action);
> +    addAction(action);
>      return action;
>      }
>
>
>  void KActionCategory::addAction(QAction *action)
>      {
> -    d->actions.append(action);
> +    // Only add the action if wasn't added earlier.
> +    if (d->actions.count(action) == 0)

!contains() ?
[prev in list] [next in list] [prev in thread] [next in thread]