[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2008-11-19 23:26:44
Message-ID: e93871060811191526g56e05516wa5a27a4e117bf0ac () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 19, 2008 at 11:12 PM, Dan Meltzer
<parallelgrapefruit@gmail.com> wrote:
> On Wed, Nov 19, 2008 at 4:43 PM, Mark Kretschmann <kretschmann@kde.org> wrote:
>> On Wed, Nov 19, 2008 at 10:13 PM, Dan Meltzer
>> <parallelgrapefruit@gmail.com> wrote:
>>> On Wed, Nov 19, 2008 at 3:55 PM, Mark Kretschmann <kretschmann@kde.org> wrote:
>>>> SVN commit 886693 by markey:
>>>>
>>>> Make the collection scanner actually call Amarok's SqlCollection D-Bus
>>>> interface correctly.
>>>
>>> I'm thinking that it might make more sense to add a parameter for the
>>> pid of amarok (--amarokpid?), rather than using collectionid for
>>> this... just looking at this code does not really describe accurately
>>> what it does, and might cause confusion in the future.
>>
>> Yeah Mr. Armchair Reviewer, I'm aware of that. This was a hack to get
>> this fucking code working FAST. I didn't write this crap, I only spent
>> 10 hours debugging it.
>
> Yes, but as you are probably also aware, many hacks that make their
> way into amaroks code remain in amarok's code for years.  I'd much
> prefer to sit in the armchair and make noise when one of these hacks
> wanders in that shouldn't than to sit back and watch the code base
> become a nest of spaggeti again.
>
> It would have taken three more minutes to make this work right.  Those
> three minutes will easily pay off in the long haul, and as this code
> has been broken since 2.0 started... I can't imagine that anyone would
> have complained if this code wandered in three minutes later.

How about you shut the fuck up and fix it instead of lamenting about
other people's work, hm?

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org
[prev in list] [next in list] [prev in thread] [next in thread]