[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kblog
From:       Allen Winter <winter () kde ! org>
Date:       2008-11-19 0:42:18
Message-ID: 200811181942.20542.winter () kde ! org
[Download RAW message or body]

On Tuesday 18 November 2008 7:13:41 pm Christian Weilbach wrote:
> SVN commit 886325 by weilbach:
> 
> Patch by Mehrdad: Problem: "Kblog joins tags with a Space delimiter and create a \
>                 big tag, while sending a post" fixed.
> Problem: "on listRecentPosts(), KBlog doesn't set some properties of posts, like \
> tags." fixed. Joining tags with "," instead of " " fixed in MovableType as well.
> 
Should we backport this to 4.1, for the 4.1.4 release?

> 
> M  +8 -0      blogpost.cpp  
> M  +1 -1      movabletype.cpp  
> M  +2 -2      wordpressbuggy.cpp  
> 
> 
> --- trunk/KDE/kdepimlibs/kblog/blogpost.cpp #886324:886325
> @@ -42,6 +42,14 @@
> d_ptr->mTitle = post.title();
> d_ptr->mContent = post.content();
> d_ptr->mCategories = post.categories();
> +  d_ptr->mTags = post.tags();
> +  d_ptr->mMood = post.mood();
> +  d_ptr->mPermaLink = post.permaLink();
> +  d_ptr->mSummary = post.summary();
> +  d_ptr->mLink = post.link();
> +  d_ptr->mMusic = post.music();
> +  d_ptr->mTrackBackAllowed = post.isTrackBackAllowed();
> +  d_ptr->mCommentAllowed = post.isCommentAllowed();
> d_ptr->mError = post.error();
> d_ptr->mJournalId = post.journalId();
> d_ptr->mStatus = post.status();
> --- trunk/KDE/kdepimlibs/kblog/movabletype.cpp #886324:886325
> @@ -204,7 +204,7 @@
> map["mt_allow_comments"] = (int)post.isCommentAllowed();
> map["mt_allow_pings"] = (int)post.isTrackBackAllowed();
> map["mt_excerpt"] = post.summary();
> -  map["mt_keywords"] = post.tags(); // TODO some conversion needed?
> +  map["mt_keywords"] = post.tags().join(",");
> //map["mt_tb_ping_urls"] check for that, i think this should only be done on the \
>                 server.
> *args << map;
> *args << QVariant( !post.isPrivate() );
> --- trunk/KDE/kdepimlibs/kblog/wordpressbuggy.cpp #886324:886325
> @@ -111,7 +111,7 @@
> xmlMarkup += "<value><string><![CDATA[" + post->summary() + "]]></string></value>";
> xmlMarkup += "</member><member>";
> xmlMarkup += "<name>mt_keywords</name>";
> -  xmlMarkup += "<value><string><![CDATA[" + post->tags().join(" ") + \
> "]]></string></value>"; +  xmlMarkup += "<value><string><![CDATA[" + \
> post->tags().join(",") + "]]></string></value>"; xmlMarkup += \
> "</member></struct></param>"; xmlMarkup += "<param><value><boolean>" +
> QString( "%1" ).arg( (int)(!post->isPrivate() ) ) +
> @@ -207,7 +207,7 @@
> xmlMarkup += "<value><string><![CDATA[" + post->summary() + "]]></string></value>";
> xmlMarkup += "</member><member>";
> xmlMarkup += "<name>mt_keywords</name>";
> -  xmlMarkup += "<value><string><![CDATA[" + post->tags().join( " " ) + \
> "]]></string></value>"; +  xmlMarkup += "<value><string><![CDATA[" + \
> post->tags().join( "," ) + "]]></string></value>"; xmlMarkup += \
> "</member></struct></param>"; xmlMarkup += "<param><value><boolean>" +
> QString( "%1" ).arg( (int)( !post->isPrivate() ) ) +
> 


[prev in list] [next in list] [prev in thread] [next in thread]