[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/plasma
From:       Michel Hermier <michel.hermier () gmail ! com>
Date:       2008-11-13 0:55:15
Message-ID: 1226537715.970846.30744.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 883485 by hermier:

Don't leak XVisualInfo on some initialisations of ARGB (code is quite duplicated, and \
maybe at other places sighhhh)

 M  +1 -0      applets/systemtray/protocols/fdo/fdoselectionmanager.cpp  
 M  +1 -0      shells/desktop/plasmaapp.cpp  
 M  +1 -0      shells/mid/plasmaapp.cpp  
 M  +1 -0      shells/screensaver/plasmaapp.cpp  


--- trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp \
#883484:883485 @@ -277,6 +277,7 @@
             break;
         }
     }
+    XFree(xvi);
 
     XChangeProperty(d->display, winId(), d->visualAtom, XA_VISUALID, 32,
                     PropModeReplace, (const unsigned char*)&visual, 1);
--- trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp #883484:883485
@@ -105,6 +105,7 @@
                 break;
             }
         }
+        XFree(xvi);
     }
 
     kDebug() << (colormap ? "Plasma has an argb visual" : "Plasma lacks an argb \
                visual") << visual << colormap;
--- trunk/KDE/kdebase/workspace/plasma/shells/mid/plasmaapp.cpp #883484:883485
@@ -80,6 +80,7 @@
                 break;
             }
         }
+	XFree(xvi);
     }
 
     kDebug() << (colormap ? "Plasma has an argb visual" : "Plasma lacks an argb \
                visual") << visual << colormap;
--- trunk/KDE/kdebase/workspace/plasma/shells/screensaver/plasmaapp.cpp \
#883484:883485 @@ -100,6 +100,7 @@
                 break;
             }
         }
+	XFree(xvi);
     }
 
     kDebug() << (colormap ? "Plasma has an argb visual" : "Plasma lacks an argb \
visual") << visual << colormap;


[prev in list] [next in list] [prev in thread] [next in thread]