[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.1/kdepimlibs/kmime
From:       André Wöbbeking <woebbeking () kde ! org>
Date:       2008-11-06 20:49:24
Message-ID: 1226004564.869760.1306.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 880908 by woebbe:

and now fix the real leak:

the private base classes had no virtual dtor.

this made knode nearly unusable (if you wanted to run it for some time).

 M  +1 -1      kmime_content_p.h  
 M  +0 -3      kmime_headers.cpp  
 M  +2 -0      kmime_headers_p.h  


--- branches/KDE/4.1/kdepimlibs/kmime/kmime_content_p.h #880907:880908
@@ -32,7 +32,7 @@
       defaultCS = KMime::cachedCharset( "ISO-8859-1" );
     }
 
-    ~ContentPrivate()
+    virtual ~ContentPrivate()
     {
       qDeleteAll( contents );
       contents.clear();
--- branches/KDE/4.1/kdepimlibs/kmime/kmime_headers.cpp #880907:880908
@@ -1190,9 +1190,6 @@
 
 Generic::~Generic()
 {
-  Q_D(Generic);
-  delete[] d->type;
-  d->type = 0;
 }
 
 void Generic::clear()
--- branches/KDE/4.1/kdepimlibs/kmime/kmime_headers_p.h #880907:880908
@@ -34,6 +34,8 @@
   public:
     BasePrivate() : parent( 0 ) {}
 
+    virtual ~BasePrivate() {}
+
     KMime::Content *parent;
     QByteArray encCS;
 };
[prev in list] [next in list] [prev in thread] [next in thread]