[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    tests/khtmltests/regression
From:       Harri Porten <porten () kde ! org>
Date:       2008-11-05 22:45:45
Message-ID: 1225925145.012598.28563.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 880602 by porten:

Testing new ugglyhack for SGML comments in JS. Fixed in r880601.


 M  +18 -14    baseline/ecma/comment.html-dom  
 D             baseline/ecma/comment.html-dump.png  
 M  +1 -0      baseline/ecma/svnignore  
 M  +7 -3      tests/ecma/comment.html  


--- trunk/tests/khtmltests/regression/baseline/ecma/comment.html-dom #880601:880602
@@ -27,6 +27,8 @@
 //                0      1      2      3     4     5     6      7     8    9
 var moz      = [ true, true, true, true, true, false, true, true, false, true ];
 //                0      1      2      3     4     5     6      7     8    9
+var opera    = [ true, true, false, false, true, false, true, false, false, true ];
+//                0      1      2      3     4     5     6      7     8    9
 /*
   Test 0: the usual old-browser prevention, should work in all browsers
   Test 1: same without the javascript comment, should work in all browsers
@@ -37,7 +39,7 @@
   Test 6: complete 1-line-comment before script, accepted
   Test 7: complete 1-line-comment after line, accepted
   Test 8: complete 1-line-comment before line, no go, everything after <!-- is \
                ignored
-  Test 9: free space for a new test ;)
+  Test 9: C-style comments are treated like whitespace it seems
   
   Tests such as a single opening comment before js code breaks parsing in IE,
   it will eat everything up until the next -->, so no such test here.
@@ -118,8 +120,9 @@
 "
       SCRIPT
         #text "
-// No more test here, feel free to add one
-test[9] = true;"
+<!-- /* <![CDATA[ */
+test[9] = true;
+/* ]]> */ -->"
       #text "
 done
 
@@ -130,27 +133,28 @@
 document.write("<p>Test " + i + "  "
            + (test[i] ? "PARSED" : "NOT PARSED") + "   "
 	   + " (" + (IE6[i] ? "Parses in IE6" : "Doesn't parse in IE6") + ")" + "  "
-	   + " (" + (moz[i] ? "Parses in Moz" : "Doesn't parse in Moz") + ")");"
+	   + " (" + (moz[i] ? "Parses in Moz" : "Doesn't parse in Moz") + ")" + "  "
+	   + " (" + (opera[i] ? "Parses in Opera" : "Doesn't parse in Opera") + ")");"
       P
-        #text "Test 0  PARSED    (Parses in IE6)   (Parses in Moz)"
+        #text "Test 0  PARSED    (Parses in IE6)   (Parses in Moz)   (Parses in \
Opera)"  P
-        #text "Test 1  PARSED    (Parses in IE6)   (Parses in Moz)"
+        #text "Test 1  PARSED    (Parses in IE6)   (Parses in Moz)   (Parses in \
Opera)"  P
-        #text "Test 2  PARSED    (Doesn't parse in IE6)   (Parses in Moz)"
+        #text "Test 2  PARSED    (Doesn't parse in IE6)   (Parses in Moz)   (Doesn't \
parse in Opera)"  P
-        #text "Test 3  PARSED    (Doesn't parse in IE6)   (Parses in Moz)"
+        #text "Test 3  PARSED    (Doesn't parse in IE6)   (Parses in Moz)   (Doesn't \
parse in Opera)"  P
-        #text "Test 4  PARSED    (Parses in IE6)   (Parses in Moz)"
+        #text "Test 4  PARSED    (Parses in IE6)   (Parses in Moz)   (Parses in \
Opera)"  P
-        #text "Test 5  NOT PARSED    (Doesn't parse in IE6)   (Doesn't parse in \
Moz)" +        #text "Test 5  NOT PARSED    (Doesn't parse in IE6)   (Doesn't parse \
in Moz)   (Doesn't parse in Opera)"  P
-        #text "Test 6  PARSED    (Parses in IE6)   (Parses in Moz)"
+        #text "Test 6  PARSED    (Parses in IE6)   (Parses in Moz)   (Parses in \
Opera)"  P
-        #text "Test 7  PARSED    (Parses in IE6)   (Parses in Moz)"
+        #text "Test 7  PARSED    (Parses in IE6)   (Parses in Moz)   (Doesn't parse \
in Opera)"  P
-        #text "Test 8  NOT PARSED    (Doesn't parse in IE6)   (Doesn't parse in \
Moz)" +        #text "Test 8  NOT PARSED    (Doesn't parse in IE6)   (Doesn't parse \
in Moz)   (Doesn't parse in Opera)"  P
-        #text "Test 9  PARSED    (Parses in IE6)   (Parses in Moz)
+        #text "Test 9  PARSED    (Parses in IE6)   (Parses in Moz)   (Parses in \
Opera)  
   "
         #text "
--- trunk/tests/khtmltests/regression/baseline/ecma/svnignore #880601:880602
@@ -1,6 +1,7 @@
 checked.html-render
 checked.html-dump.png
 comment.html-render
+comment.html-dump.png
 css.html-render
 document.html-render
 document2.html-render
--- trunk/tests/khtmltests/regression/tests/ecma/comment.html #880601:880602
@@ -17,6 +17,8 @@
 //                0      1      2      3     4     5     6      7     8    9
 var moz      = [ true, true, true, true, true, false, true, true, false, true ];
 //                0      1      2      3     4     5     6      7     8    9
+var opera    = [ true, true, false, false, true, false, true, false, false, true ];
+//                0      1      2      3     4     5     6      7     8    9
 /*
   Test 0: the usual old-browser prevention, should work in all browsers
   Test 1: same without the javascript comment, should work in all browsers
@@ -27,7 +29,7 @@
   Test 6: complete 1-line-comment before script, accepted
   Test 7: complete 1-line-comment after line, accepted
   Test 8: complete 1-line-comment before line, no go, everything after <!-- is \
                ignored
-  Test 9: free space for a new test ;)
+  Test 9: C-style comments are treated like whitespace it seems
   
   Tests such as a single opening comment before js code breaks parsing in IE,
   it will eat everything up until the next -->, so no such test here.
@@ -88,8 +90,9 @@
 </script>
 9
 <script>
-// No more test here, feel free to add one
+<!-- /* <![CDATA[ */
 test[9] = true;
+/* ]]> */ -->
 </script>
 done
 
@@ -98,7 +101,8 @@
 document.write("<p>Test " + i + "  "
            + (test[i] ? "PARSED" : "NOT PARSED") + "   "
 	   + " (" + (IE6[i] ? "Parses in IE6" : "Doesn't parse in IE6") + ")" + "  "
-	   + " (" + (moz[i] ? "Parses in Moz" : "Doesn't parse in Moz") + ")");
+	   + " (" + (moz[i] ? "Parses in Moz" : "Doesn't parse in Moz") + ")" + "  "
+	   + " (" + (opera[i] ? "Parses in Opera" : "Doesn't parse in Opera") + ")");
 </script>
 
   </body>


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic