[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/services/lastfm
From:       "Seb Ruiz" <ruiz () kde ! org>
Date:       2008-11-04 23:37:57
Message-ID: 60ebdd0b0811041537o75041360n2ffc37773ee14d80 () mail ! gmail ! com
[Download RAW message or body]

2008/11/5 Andrey Esin <gmlastik@gmail.com>:
> SVN commit 879997 by esin:
> 
> Removed validation for username
> When pressing on Default reset only checkboxes
> Adding TODO for username and password validation

Cool. Just FYI:

[10:35] <d-fens_> was there a change in the lastfm login fields not to
allow dash and underscore?
[10:35] <sebr> d-fens_: yes, does this break for you?
[10:36] <d-fens_> jepp

> 
> M  +7 -5      LastFmServiceSettings.cpp
> 
> 
> --- trunk/extragear/multimedia/amarok/src/services/lastfm/LastFmServiceSettings.cpp \
> #879996:879997 @@ -36,10 +36,6 @@
> m_configDialog = new Ui::LastFmConfigWidget;
> m_configDialog->setupUi( w );
> l->addWidget( w );
> -
> -    QRegExp rx( "[A-Za-z][A-Za-z0-9]{1,14}" );
> -    QValidator *validator = new QRegExpValidator( rx, this );
> -    m_configDialog->kcfg_ScrobblerUsername->setValidator( validator );
> 
> connect( m_configDialog->kcfg_ScrobblerUsername, SIGNAL( textChanged( const QString \
> & ) ), this, SLOT( settingsChanged() ) ); connect( \
> m_configDialog->kcfg_ScrobblerPassword, SIGNAL( textChanged( const QString & ) ), \
> this, SLOT( settingsChanged() ) ); @@ -85,12 +81,18 @@
> LastFmServiceSettings::defaults()
> {
> m_config.reset();
> -    load();
> +
> +    // By default this checkboxes is:
> +    m_configDialog->kcfg_SubmitPlayedSongs->setChecked( true );
> +    m_configDialog->kcfg_RetrieveSimilarArtists->setChecked( false );
> }
> 
> 
> void
> LastFmServiceSettings::settingsChanged()
> {
> +    //TODO: Make pretty validation for username and password
> +    //with error reporting
> +
> emit changed( true );
> }
> 



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]