[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/krita/ui
From:       Bart Coppens <kde () bartcoppens ! be>
Date:       2008-11-02 16:12:23
Message-ID: 1225642343.033302.477.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 879187 by coppens:

Don't try to calculate log(0) when drawing logarithmic histogram plots. Fixes the \
weird problems where almost everything was drawn in  black (and where in my test \
image the 0-value of green was obviously wrong as well). I can only wonder how this \
ever worked in 1.6 :-) (perhaps Qt  just didn't draw lines with those ridiculous \
coordinates?)


 M  +4 -2      kis_histogram_view.cc  


--- trunk/koffice/krita/ui/kis_histogram_view.cc #879186:879187
@@ -342,8 +342,10 @@
                 } else {
                     p.setPen(color);
                 }
-                p.drawLine(i, height, i,
-                           height - int(log((double)m_histogram->getValue(i)) * \
factor)); +                if (m_histogram->getValue(i) > 0) { // Don't try to \
calculate log(0) +                    p.drawLine(i, height, i,
+                               height - int(log((double)m_histogram->getValue(i)) * \
factor)); +                }
             }
         }
     }


[prev in list] [next in list] [prev in thread] [next in thread]