[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/amarok/src/configdialog
From:       Seb Ruiz <ruiz () kde ! org>
Date:       2008-11-02 10:52:28
Message-ID: 1225623148.924306.5124.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 878977 by seb:

Correctly show the requested config dialog page when asked for.


 M  +6 -6      ConfigDialog.cpp  
 M  +1 -0      ConfigDialog.h  


--- trunk/extragear/multimedia/amarok/src/configdialog/ConfigDialog.cpp #878976:878977
@@ -80,19 +80,19 @@
 
     // Add the widget pointer to our list, for later reference
     m_pageList << page;
-
-    KConfigDialog::addPage( page, itemName, pixmapName, header, manage );
+    KPageWidgetItem *pageWidget = KConfigDialog::addPage( page, itemName, pixmapName, header, manage );
+    m_pageMap.insert( page, pageWidget );
 }
 
 /** Show page by object name */
 void Amarok2ConfigDialog::showPageByName( const QString& page )
 {
-    DEBUG_BLOCK
-    for( int index = 0; index < m_pageList.count(); index++ )
+    foreach( ConfigDialogBase *configPage, m_pageList )
     {
-        if( m_pageList[index]->objectName() == page )
+        if( configPage->objectName() == page )
         {
-            KConfigDialog::setCurrentPage( qobject_cast<KPageWidgetItem*>( m_pageList[index] ) );
+            KPageWidgetItem *pageItem = m_pageMap.value( configPage );
+            KConfigDialog::setCurrentPage( pageItem );
             return;
         }
     }
--- trunk/extragear/multimedia/amarok/src/configdialog/ConfigDialog.h #878976:878977
@@ -52,6 +52,7 @@
 
     private:
         QList<ConfigDialogBase*> m_pageList;
+        QMap<ConfigDialogBase*,KPageWidgetItem*> m_pageMap;
 };
 
 
[prev in list] [next in list] [prev in thread] [next in thread]