[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/libs/plasma
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2008-11-01 22:01:33
Message-ID: 1225576893.991395.16614.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 878840 by aseigo:

package metadat by reference, not pointer, for API clarity and health 


 M  +2 -2      package.cpp  
 M  +1 -1      package.h  


--- trunk/KDE/kdebase/workspace/libs/plasma/package.cpp #878839:878840
@@ -177,13 +177,13 @@
     return QStringList();
 }
 
-const PackageMetadata *Package::metadata() const
+PackageMetadata Package::metadata() const
 {
     //FIXME: this only works for native plasma packges; should fall back to... PackageStructure?
     if (!d->metadata) {
         d->metadata = new PackageMetadata(d->basePath + "metadata.desktop");
     }
-    return d->metadata;
+    return *d->metadata;
 }
 
 const QString Package::path() const
--- trunk/KDE/kdebase/workspace/libs/plasma/package.h #878839:878840
@@ -101,7 +101,7 @@
         /**
           * @return the package metadata object.
           */
-        const PackageMetadata *metadata() const;
+        PackageMetadata metadata() const;
 
         /**
          * @return the path to the root of this particular package
[prev in list] [next in list] [prev in thread] [next in thread]