[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: KDE/kdebindings/php/phpqt
From: Thomas Moenicke <tm () php-qt ! org>
Date: 2008-11-01 2:10:20
Message-ID: 1225505420.513106.22766.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 878385 by moenicke:
* cleaning
M +2 -9 src/MethodCall.cpp
M +1 -7 src/php_qt.cpp
M +0 -1 src/qstring.cpp
M +2 -2 tests/QtBasicTestCase.php
--- trunk/KDE/kdebindings/php/phpqt/src/MethodCall.cpp #878384:878385
@@ -13,14 +13,7 @@
_o(0),
_retval(retval),
_staticCall( false )
- {
- if( target == 0 )
- {
- _target = (zval*) emalloc( sizeof(zval) );
- _retval = (zval*) emalloc( sizeof(zval) );
- _staticCall = true;
- }
-
+{
if (PHPQt::SmokePHPObjectExists(_target))
{
smokephp_object *o = PHPQt::getSmokePHPObjectFromZval(_target);
@@ -34,7 +27,7 @@
_items = _smoke->methods[_method].numArgs;
// TODO memory test
_stack = new Smoke::StackItem[_items + 1];
- }
+}
MethodCall::~MethodCall()
{
--- trunk/KDE/kdebindings/php/phpqt/src/php_qt.cpp #878384:878385
@@ -280,12 +280,7 @@
smokephp_prepareMethodName(args, argc);
const Smoke::Index method = smokephp_getMethod(ce->name, \
Context::methodName()->constData(), argc, args);
- // for static methods that are called on an object
- if( PQ::smoke()->methods[ method ].flags & Smoke::mf_static )
- {
- pNotice() << "called static method on an object" << Context::methodName();
- this_ptr = 0;
- }
+
if(method <= 0) { // its a user signal
if( Context::methodName()->constData() ) {
@@ -353,7 +348,6 @@
ZEND_METHOD(php_qt_generic_class, staticProxyMethod)
{
Context::setCallType( Context::StaticMethodCall );
- qDebug() << Context::callType();
ALLOC_INIT_ZVAL( this_ptr );
object_init_ex( this_ptr, Context::activeCe() );
--- trunk/KDE/kdebindings/php/phpqt/src/qstring.cpp #878384:878385
@@ -581,7 +581,6 @@
ZEND_METHOD(QString, __destruct)
{
- qDebug() << "__destruct";
zim_php_qt_generic_class___destruct(ht, return_value, return_value_ptr, \
this_ptr, return_value_used); }
--- trunk/KDE/kdebindings/php/phpqt/tests/QtBasicTestCase.php #878384:878385
@@ -66,8 +66,8 @@
$o = new QObject();
$p = new foo($o);
// set blockSignals to true, so we can test it
- $p->blockSignals(true);
- $this->assertTrue($p->blockSignals(true), "Could not call a parent Qt \
method!"); +// $p->blockSignals(true);
+// $this->assertTrue($p->blockSignals(true), "Could not call a parent Qt \
method!"); echo " passed";
}
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic