[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdegraphics/kolourpaint/tools/selection/text
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2008-10-24 19:26:45
Message-ID: 200810242126.46738.aacid () kde ! org
[Download RAW message or body]

A Divendres 24 Octubre 2008, Shai Berger va escriure:
> SVN commit 875545 by sberger:
>
> Use QKeyEvent::text() to see if a keypress generate text, rather than
> compare key code to 256 (the old method broke writing utf text out of
> iso-latin-1)
>
> CCMAIL: kde-il@yahoogroups.com
>
> BUG: 156122

I think you should backport this to the 4.1 branch, according to 
http://techbase.kde.org/Schedules/KDE4/4.1_Release_Schedule we are still 
having at least another release more.

Albert

>
>
>
>  M  +1 -1      kpToolText_KeyboardEvents.cpp
>
>
> ---
> trunk/KDE/kdegraphics/kolourpaint/tools/selection/text/kpToolText_KeyboardE
>vents.cpp #875544:875545 @@ -89,7 +89,7 @@
>      // TODO: don't like this check
>      else if ((ke->modifiers () &
>                  (Qt::ControlModifier | Qt::AltModifier |
> Qt::MetaModifier)) == 0 && -            ke->key () < 0x100 /*QChar (ke->key
> ()).isPrint () - unfortunately F1 is printable too...*/) +             !(
> ke->text ().isEmpty ()))
>      {
>      #if DEBUG_KP_TOOL_TEXT
>          kDebug () << "\tis text - grab";


[prev in list] [next in list] [prev in thread] [next in thread]