[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/rendering
From:       Maks Orlovich <maksim () kde ! org>
Date:       2008-10-22 22:13:18
Message-ID: 1224713598.561052.18077.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 874968 by orlovich:

Merged revision 874965:
Fix crash when fixed-layout tables (wow, someone actually uses those?) 
specify all % width as 0 (affects new ebay myebay version)
BUG: 172557

 M  +4 -2      table_layout.cpp  


--- branches/KDE/3.5/kdelibs/khtml/rendering/table_layout.cpp #874967:874968
@@ -297,7 +297,8 @@
 #endif
         for ( int i = 0; available > 0 && i < nEffCols; i++ ) {
             if ( width[i].isPercent() ) {
-                int w = base * width[i].value() / totalPercent;
+                // totalPercent may be 0 below if all %-width specifed are 0%. (#172557)
+                int w = totalPercent ? base * width[i].value() / totalPercent : 0;
                 available -= w;
                 calcWidth[i] = w;
             }
@@ -313,7 +314,8 @@
 
         for ( int i = 0; available > 0 && i < nEffCols; i++ ) {
             if ( width[i].isVariable() ) {
-                int w = available / totalVariable;
+                // totalVariable may be 0 below if all the variable widths specified are 0.
+                int w = totalVariable ? available / totalVariable : 0;
                 available -= w;
                 calcWidth[i] = w;
 		totalVariable--;
[prev in list] [next in list] [prev in thread] [next in thread]