[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeplasma-addons/applets/dict
From:       Davide Bettio <davbet () aliceposta ! it>
Date:       2008-10-17 17:09:33
Message-ID: 1224263373.423765.28354.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 872625 by bettio:

Calling updateGeometry() from constraintsEvent *is never* a good idea. Please don't do that.
CCMAIL: plasma-devel@kde.org 


 M  +0 -10     dict.cpp  
 M  +0 -1      dict.h  


--- trunk/KDE/kdeplasma-addons/applets/dict/dict.cpp #872624:872625
@@ -114,16 +114,6 @@
     define();
 }
 
-void Dict::constraintsEvent(Plasma::Constraints constraints)
-{
-    if (constraints & Plasma::FormFactorConstraint) {
-        //updateGeometry();
-    }
-    if (constraints & Plasma::SizeConstraint) {
-        updateGeometry();
-    }
-}
-
 void Dict::dataUpdated(const QString& source, const Plasma::DataEngine::Data &data)
 {
     Q_UNUSED(source);
--- trunk/KDE/kdeplasma-addons/applets/dict/dict.h #872624:872625
@@ -48,7 +48,6 @@
 
     void init();
         void setPath(const QString&);
-        void constraintsEvent(Plasma::Constraints);
 
     public slots:
         void dataUpdated(const QString &name, const Plasma::DataEngine::Data &data);
[prev in list] [next in list] [prev in thread] [next in thread]