[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/kwin
From:       Luboš Luňák <l.lunak () kde ! org>
Date:       2008-10-14 10:34:37
Message-ID: 1223980477.266604.21624.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 871255 by lunakl:

A hack to disable unredirect for login splashscreen, better solution would
be to add support for effects refcounting the window.
BUG: 172276



 M  +4 -0      composite.cpp  
 M  +1 -1      effects/login.cpp  


--- trunk/KDE/kdebase/workspace/kwin/composite.cpp #871254:871255
@@ -899,6 +899,10 @@
 
 bool Unmanaged::shouldUnredirect() const
     {
+    // the pixmap is needed for the login effect, a nicer solution would be the \
login effect increasing +    // refcount for the window pixmap (which would prevent \
unredirect), avoiding this hack +    if( resourceClass() == "ksplashx" || \
resourceClass() == "ksplashsimple" ) +        return false;
 // it must cover whole display or one xinerama screen, and be the topmost there
     if( geometry() == workspace()->clientArea( FullArea, geometry().center(), \
                workspace()->currentDesktop())
         || geometry() == workspace()->clientArea( ScreenArea, geometry().center(), \
                workspace()->currentDesktop()))
--- trunk/KDE/kdebase/workspace/kwin/effects/login.cpp #871254:871255
@@ -98,7 +98,7 @@
 
 bool LoginEffect::isLoginSplash( EffectWindow* w )
     { // TODO there should be probably a better way (window type?)
-    // see also fade effect
+    // see also fade effect and composite.cpp
     if( w->windowClass() == "ksplashx ksplashx"
         || w->windowClass() == "ksplashsimple ksplashsimple" )
         {


[prev in list] [next in list] [prev in thread] [next in thread]