[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepimlibs/kioslave/imap4
From:       Thiago Macieira <thiago () kde ! org>
Date:       2008-10-10 7:46:15
Message-ID: 1223624775.505766.4817.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 869815 by thiago:

Fix kio_imap4 slowness.

Porting issue. There's absolutely no need to use QBuffer to append stuff to a QByteArray.

 M  +3 -6      imap4.cpp  


--- trunk/KDE/kdepimlibs/kioslave/imap4/imap4.cpp #869814:869815
@@ -737,12 +737,9 @@
       }
       // append to buffer
       {
-        QBuffer stream (&buffer);
-
-        stream.open (QIODevice::WriteOnly);
-        stream.seek (buffer.size ());
-        stream.write (readBuffer, copyLen);
-        stream.close ();
+        int oldsize = buffer.size();
+        buffer.resize(oldsize + copyLen);
+        memcpy(buffer.data() + oldsize, readBuffer, copyLen);
 //        kDebug(7116) <<"appended" << copyLen <<"d got now" << buffer.size();
       }
 
[prev in list] [next in list] [prev in thread] [next in thread]