[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/konsole/src
From:       André_Wöbbeking <Woebbeking () kde ! org>
Date:       2008-10-09 17:52:09
Message-ID: 200810091952.10629.Woebbeking () kde ! org
[Download RAW message or body]

On Thursday 09 October 2008, Thiago Macieira wrote:
> SVN commit 869659 by thiago:
>
> The containerWidget is used by ViewSplit, which calls addWidget,
> which in turn sets the parent. So don't delete it if it has already
> been deleted.
>
> If we are sure that the containerWidget will be parented, we can
> avoid the QPointer
>
>  M  +4 -2      ViewContainer.cpp
>  M  +3 -2      ViewContainer.h
>
>
> --- trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp
> #869658:869659 @@ -585,7 +585,8 @@
>  }
>  TabbedViewContainer::~TabbedViewContainer()
>  {
> -    _containerWidget->deleteLater();
> +    if (!_containerWidget.isNull())

Why not just

    if (_containerWidget)

It's shorter and looks more like a pointer.
[prev in list] [next in list] [prev in thread] [next in thread]