[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim
From:       David Faure <dfaure () kdab ! net>
Date:       2008-10-08 14:12:49
Message-ID: 200810081612.51910.dfaure () kdab ! net
[Download RAW message or body]

On Wednesday 08 October 2008, Marc Mutz wrote:
> On Wednesday October 8 2008, Matthias Fuchs wrote:
> > SVN commit 869194 by mfuchs:
> >
> > Fix some compiler warnings.
> 
> Please switch those warning off. They're bogus.
> Please revert.

Well, they make the code more obvious to non-C++-expert (i.e. everyone else but you)...
Increasing the number of people who can read the code (without thinking there's a bug
where there isn't one) is never a bad idea.
Everyone not having the rules in mind for if / if / else or (a&&b||c&&d||e) shouldn't have
to open a book just to understand the code. And even more importantly, those warnings 
help (in code written by others, not in yours) detect bugs, so they should not be turned off.

-- 
David Faure, faure@kde.org, dfaure@kdab.net
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]