[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/systemsettings
From:       Michael Jansen <kde () michael-jansen ! biz>
Date:       2008-10-07 21:07:31
Message-ID: 200810072307.32256.kde () michael-jansen ! biz
[Download RAW message or body]

On Tuesday 07 October 2008 22:16:26 Urs Wolfer wrote:
> SVN commit 868980 by uwolfer:
>
> Use a standard action here; less code and I hoped to get the standard
> shortcut for it (alt+left)... which seems not the case. Any ideas?
> CCMAIL:kde@michael-jansen.biz

not yet.


> showOverviewAction = KStandardAction::back(this, SLOT(showOverview()), 
actionCollection());
> actionCollection()->addAction("showAll", showOverviewAction);

It is not necessary to add the action to the collection because 
KStandardAction::back() does it implicitly. This seems to be a very common 
misconception in kde code.

I just checked and the api doc doesn't document that behavior. I think we 
should fix that.

Mike

-- 
Michael Jansen

http://www.michael-jansen.biz
[prev in list] [next in list] [prev in thread] [next in thread]