[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.1/kdelibs/khtml/ecma
From:       Harri Porten <porten () kde ! org>
Date:       2008-10-05 21:35:28
Message-ID: 1223242528.123249.29200.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 868286 by porten:

Merged revision 868284:
Readability.

 M  +8 -8      kjs_css.cpp  


--- branches/KDE/4.1/kdelibs/khtml/ecma/kjs_css.cpp #868285:868286
@@ -69,7 +69,7 @@
 
 namespace KJS {
 
-static QString cssPropertyName( const Identifier &p, bool& hadPixelPrefix )
+static QString cssPropertyName( const Identifier &p, bool* hadPixelPrefix )
 {
     // The point here is to provide compatibility with IE 
     // syntax for accessing properties, which camel-cases them
@@ -82,16 +82,16 @@
     }
 
     prop = prop.toLower();
-    hadPixelPrefix = false;
+    *hadPixelPrefix = false;
 
     if (prop.startsWith(QLatin1String("css-"))) {
         prop = prop.mid(4);
     } else if (prop.startsWith(QLatin1String("pixel-"))) {
         prop = prop.mid(6);
-        hadPixelPrefix = true;
+        *hadPixelPrefix = true;
     } else if (prop.startsWith(QLatin1String("pos-"))) {
         prop = prop.mid(4);
-        hadPixelPrefix = true;
+        *hadPixelPrefix = true;
     }
 
     return prop;
@@ -108,8 +108,8 @@
 static bool isCSSPropertyName(const Identifier &JSPropertyName)
 {
     bool dummy;
-    QString p = cssPropertyName(JSPropertyName, dummy);
-    return cssPropertyId(p);
+    QString p = cssPropertyName(JSPropertyName, &dummy);
+    return cssPropertyId(p) != 0;
 }
 
 
@@ -192,7 +192,7 @@
     // positioned element. if it is not a positioned element, return 0
     // from MSIE documentation ### IMPLEMENT THAT (Dirk)
     bool asNumber;
-    DOMString p   = cssPropertyName(propertyName, asNumber);
+    DOMString p   = cssPropertyName(propertyName, &asNumber);
 
     if (asNumber) {
       CSSValueImpl *v = m_impl->getPropertyCSSValue(p);
@@ -225,7 +225,7 @@
   }
   else {
     bool pxSuffix;
-    QString prop = cssPropertyName(propertyName, pxSuffix);
+    QString prop = cssPropertyName(propertyName, &pxSuffix);
     QString propvalue = value->toString(exec).qstring();
 
     if (pxSuffix)
[prev in list] [next in list] [prev in thread] [next in thread]