[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/libs/plasma
From:       Rob Scheepmaker <r.scheepmaker () student ! utwente ! nl>
Date:       2008-10-05 10:34:59
Message-ID: 200810051234.59913.r.scheepmaker () student ! utwente ! nl
[Download RAW message or body]

On Friday 03 October 2008 19:20:02 Aaron J. Seigo wrote:
> SVN commit 867506 by aseigo:
>
> * remove an unused member (d->layout)
> * try harder to create a layout when we might need one
> * remove the "setting a default icon" stuff in the ctor; it was misguided
> and really just covering up for a bug in popupConstraintsEvent * fix said
> bug in popupConstraintsEvent (don't check for icon before laying things out
> in non-vert/horiz formfactors) * don't put an event filter on the graphics
> item. i have no idea what the idea behind that was (hooray for no comments!
> =), perhaps Richard S. can enlighten us as it was one of his commits ..

Assuming you mean Rob S.... ;)
The reason for the eventfilter is to resize the applet when on the desktop, 
and the widget it contains shrinks or grows. You would assume that 
QGraphicsLayout would take care of that, but for some reason QGL allows the 
layout to grow outside the parent widget, so you get widgets sticking out your 
applet background. I added that code to avoid that. Sorry for the lack of 
documentation.
I really really hope QGL gets a lot saner in Qt4.5. Any idea if that's on the 
feature plan?

Regards,
Rob
[prev in list] [next in list] [prev in thread] [next in thread]