[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/base/plasma/applets/systray-refactor
From:       Jason Stubbs <jasonbstubbs () gmail ! com>
Date:       2008-10-05 3:36:10
Message-ID: 1223177770.003717.10518.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 867949 by jstubbs:

Workaround QGraphicsLayout's excessive caching by manually updating sizeHints


 M  +0 -3      TODO  
 M  +3 -2      ui/applet.cpp  


--- trunk/playground/base/plasma/applets/systray-refactor/TODO #867948:867949
@@ -1,6 +1,3 @@
-* Sizing is wrong (again) when in the panel.
-  - Stop using a layout in Applet and manage sizeHint manually
-
 * The correct icon isn't being set on notifications (internal API issue)
   - Change appIcon() type to QIcon and adjust other parts accordingly
     - Unrelated to the issue, but also change app to application
--- trunk/playground/base/plasma/applets/systray-refactor/ui/applet.cpp #867948:867949
@@ -130,9 +130,10 @@
 void Applet::checkSizes()
 {
     d->taskArea->layout()->updateGeometry();
-    layout()->updateGeometry();
 
-    QSizeF preferredSize = effectiveSizeHint(Qt::PreferredSize);
+    QSizeF preferredSize = d->taskArea->effectiveSizeHint(Qt::PreferredSize);
+    setPreferredSize(preferredSize);
+
     QSizeF actualSize = size();
 
     if (formFactor() == Plasma::Planar && (actualSize.width() < preferredSize.width() ||
[prev in list] [next in list] [prev in thread] [next in thread]