[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdegames/ksudoku/src/gui/views
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2008-09-20 1:06:53
Message-ID: 20080920010653.GC32231 () morpheus ! apaku ! dnsalias ! org
[Download RAW message or body]

On 20.09.08 08:18:35, Brad Hards wrote:
> On Saturday 20 September 2008 05:24:56 am Andreas Pakulat wrote:
> > SVN commit 862763 by apaku:
> >
> > Revert 851695, its wrong as it changes the meaning of the sequence
> > making the shortcut useless. The intention of the code is to set a
> > shortcut of Shift+<something>, not Shift, then press something which
> > simply doesn't work at all.
> > I have no Qt4.5 prerelease to test against and btw, if this code breaks
> > with a new Qt release its a bug in Qt as its supposed to be backwards
> > source compatible I suggest to talk to TT about this.
> I got no answer on my question to qt-interest
> http://lists.trolltech.com/qt-interest/2008-08/thread00544-0.html

I remember seeing that mail, I suggest to mail qt-bugs or qt4-preview
mailinglist if you're trying pre-releases.
 
> > --- trunk/KDE/kdegames/ksudoku/src/gui/views/gameactions.cpp #862762:862763
> > @@ -67,9 +67,9 @@
> >  		m_collection->addAction(QString("val-mark%1").arg(i+1,2,10,QChar('0')),
> > a); a->setText(i18n("Mark %1 (%2)", QChar('a'+i), i+1));
> >  		shortcut = a->shortcut();
> > -		shortcut.setPrimary(QKeySequence(Qt::ShiftModifier, Qt::Key_A + i));
> > +		shortcut.setPrimary( Qt::ShiftModifier | Qt::Key_A + i);
> >  		if(i < 9) {
> > -		        shortcut.setAlternate(QKeySequence(Qt::ShiftModifier, Qt::Key_1
> > + i)); +			shortcut.setAlternate( Qt::ShiftModifier | Qt::Key_1 + i);
> >  		}
> >  		a->setShortcut(shortcut);
> >  		m_markValueMapper->setMapping(a, i+1);
> Does
> shortcut.setPrimary(QKeySequence(Qt::ShiftModifier + Qt::Key_A + i));
> and
> shortcut.setAlternate(QKeySequence(Qt::ShiftModifier + Qt::Key_1 + i));
> work for you?

I can't test right now, but that should work - if not there's a serious
bug in Qt :) The problem was that you created an emacs-like shortcut by
using the comma with one part being just shift, which doesn't work at
all :)

I still think this is something that TT shouldn't do because of
backwards compatibility reasons and hence someone should file a
bugreport with them.

Andreas

-- 
You will inherit some money or a small piece of land.
[prev in list] [next in list] [prev in thread] [next in thread]