[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdenetwork/kppp
From:       André Wöbbeking <woebbeking () kde ! org>
Date:       2008-09-14 16:30:44
Message-ID: 1221409844.081138.3182.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 860924 by woebbe:

warning: suggest parentheses around comparison in operand of |


 M  +2 -2      opener.cpp  


--- trunk/KDE/kdenetwork/kppp/opener.cpp #860923:860924
@@ -195,8 +195,8 @@
 	Debug("Opener: received OpenLock\n");
 	MY_ASSERT(len == sizeof(struct OpenLockRequest));
 	flags = request.lock.flags;
-	MY_ASSERT(flags == O_RDONLY || flags == O_WRONLY|O_TRUNC|O_CREAT);
-	if(flags == O_WRONLY|O_TRUNC|O_CREAT)
+	MY_ASSERT(flags == O_RDONLY || flags == (O_WRONLY|O_TRUNC|O_CREAT));
+	if(flags == (O_WRONLY|O_TRUNC|O_CREAT))
 	  mode = 0644;
 	else
 	  mode = 0;
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic