On Friday 12 September 2008 16:47:25 David Jarvie wrote: > SVN commit 860376 by djarvie: > > Backport of revision 859714, 859717 by Kevin Krammer > > Always check for self assignment in operator=(), especially when clearing things prior to copying or when juggling pointers > Ok. I assume you are really, really, really sure this can't break anything. Remember this branch is frozen except for obvious important bugfixes. > > M +2 -0 incidence.cpp > > > --- branches/KDE/3.5/kdepim/libkcal/incidence.cpp #860375:860376 > @@ -107,6 +107,8 @@ > > Incidence& Incidence::operator=( const Incidence &i ) > { > + if ( &i == this ) > + return *this; > IncidenceBase::operator=( i ); > mRevision = i.mRevision; > mCreated = i.mCreated; >