From kde-commits Wed Sep 10 00:00:59 2008 From: Maks Orlovich Date: Wed, 10 Sep 2008 00:00:59 +0000 To: kde-commits Subject: branches/KDE/4.1/kdelibs/khtml/css Message-Id: <1221004859.506965.7367.nullmailer () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=122100486929474 SVN commit 859305 by orlovich: Fix a regression in background: shorthand parsing: parseBackgroundPositionXY was impropertly setting the out position when it didn't match, which incorrect classified the position of a missing 2nd coordinate in a shorthard as non-keyword, hence dropping the rule if the first one was vertical BUG:170755 M +4 -2 cssparser.cpp --- branches/KDE/4.1/kdelibs/khtml/css/cssparser.cpp #859304:859305 @@ -1500,10 +1500,12 @@ } return new CSSPrimitiveValueImpl(percent, CSSPrimitiveValue::CSS_PERCENTAGE); } - kindOut = BgPos_NonKW; - if (validUnit(valueList->current(), FPercent|FLength, strict)) + + if (validUnit(valueList->current(), FPercent|FLength, strict)) { + kindOut = BgPos_NonKW; return new CSSPrimitiveValueImpl(valueList->current()->fValue, (CSSPrimitiveValue::UnitTypes)valueList->current()->unit); + } return 0; }