[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdenetwork/kopete/protocols/oscar/icq/ui (silent) [POSSIBLY
From:       Matt Rogers <mattr () kde ! org>
Date:       2008-09-08 21:41:04
Message-ID: 1B72E9DD-12F4-4060-9EE3-4FA07379384E () kde ! org
[Download RAW message or body]


On Sep 8, 2008, at 3:34 AM, Nick Shaforostoff wrote:

> On Mon, 08 Sep 2008 06:02:01 +0300, Matt Rogers <mattr@kde.org> wrote:
>> Why are you using QLocale here? Kopete won't honor the KDE settings  
>> for languages now. This makes KDE_LANG useless, among other  
>> possible side effects.
>
> I just copied the code from solid (it doesn't link to <KGlobal>  
> containing lib),
> and dealing with enums is faster (i guess that switch statement is  
> even
> gets converted to the mapping during -O2 compilation).
> This is hack (with results editable by user) anyways, so covering  
> most common cases is enough.
> and besides, this default codepage setting generation may be  
> triggered on a new system when
> kde language haven't been configured yet.
>
>
>
>> Perhaps you could define constants and use those for all the magic  
>> numbers here. Perhaps the mappings in icqprotocol.h are useful for  
>> you and those could be used, which would be even better
> i think that compiler should do the job.


And I think I'd rather have readable code when I have to go back and  
maintain the stuff that's there, so I would appreciate it if you would  
take one of the two actions I posted above.
--
Matt

[prev in list] [next in list] [prev in thread] [next in thread]