[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    RE: KDE/kdebase/workspace/kcontrol/colors
From:       "Matthew Woehlke" <mwoehlke () tibco ! com>
Date:       2008-09-04 18:58:10
Message-ID: C04A623342E01549B395A84F4D61FDBA0E09C8 () NA-PA-VBE03 ! na ! tibco ! com
[Download RAW message or body]

FYI: If you hadn't noticed already, I reverted this*; having to change a
color and hit 'apply' just so you can go back to the first tab to see if
the new pick is legible is... shall we say, "problematic"? :-) There's a
reason I put a preview on the "Colors" tab in the first place.

Next time, it would be nice if you at least let me know when you're
making massive changes to my UI's. (And no, expecting me to watch
commits, which obviously I haven't been doing, is not sufficient.) I
also happen to dislike how the tabs got broken up, though it's hard to
argue with your reason for doing it :-), but I would have appreciated
being warned in advance.

(* ...and I would have said something first, but you weren't on IRC and
I was too lazy to spend more than a minute looking for an e-mail address
;-).)

-- 
Matthew

-----Original Message-----
From: Sebastian Sauer [mailto:mail@dipe.org] 
Sent: Saturday, August 23, 2008 22:51
To: kde-commits@kde.org
Subject: KDE/kdebase/workspace/kcontrol/colors

SVN commit 851586 by sebsauer:

not needed to show there a preview too

 M  +0 -1      colorscm.cpp  
 M  +0 -31     colorsettings.ui  


--- trunk/KDE/kdebase/workspace/kcontrol/colors/colorscm.cpp
#851585:851586 @@ -136,7 +136,6 @@  void KColorCm::updatePreviews()  {
     schemePreview->setPalette(m_config);
-    colorPreview->setPalette(m_config);
     inactivePreview->setPalette(m_config, QPalette::Inactive);
     disabledPreview->setPalette(m_config, QPalette::Disabled);  }
--- trunk/KDE/kdebase/workspace/kcontrol/colors/colorsettings.ui
#851585:851586 @@ -561,37 +561,6 @@
          </widget>
         </widget>
        </item>
-       <item>
-        <widget class="QGroupBox" name="groupBox_4" >
-         <property name="minimumSize" >
-          <size>
-           <width>0</width>
-           <height>0</height>
-          </size>
-         </property>
-         <property name="title" >
-          <string>Preview</string>
-         </property>
-         <layout class="QVBoxLayout" name="verticalLayout_4" >
-          <item>
-           <widget class="PreviewWidget" native="1" name="colorPreview"
>
-            <property name="sizePolicy" >
-             <sizepolicy vsizetype="Fixed" hsizetype="Preferred" >
-              <horstretch>0</horstretch>
-              <verstretch>0</verstretch>
-             </sizepolicy>
-            </property>
-            <property name="minimumSize" >
-             <size>
-              <width>0</width>
-              <height>10</height>
-             </size>
-            </property>
-           </widget>
-          </item>
-         </layout>
-        </widget>
-       </item>
       </layout>
      </widget>
      <widget class="QWidget" name="effectsPage" >

[prev in list] [next in list] [prev in thread] [next in thread]