[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/KDE/4.1/kdelibs/khtml/ecma
From:       "Maksim Orlovich" <mo85 () cornell ! edu>
Date:       2008-08-26 17:13:37
Message-ID: 53404.128.84.98.220.1219770817.squirrel () webmail ! cornell ! edu
[Download RAW message or body]

>> --- branches/KDE/4.1/kdelibs/khtml/ecma/kjs_html.cpp #852715:852716
>> @@ -461,7 +461,7 @@
>>        return;
>>      }
>>      case DesignMode:
>> -        doc.setDesignMode((value->toString(exec).qstring()=="on"));
>> +
>> doc.setDesignMode((value->toString(exec).qstring().toLower()=="on"));
>
> If you need it fast you can use QString::compare() with
> Qt::CaseInsensitive.

Considering this is going from JSValue to UString to QString, I think the
extra lowercase string doesn't hurt all that much. But thanks.
(And no, it's not hot at all).


[prev in list] [next in list] [prev in thread] [next in thread]