[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/plasma/shells/mid
From:       "Jason Stubbs" <jasonbstubbs () gmail ! com>
Date:       2008-08-25 8:06:17
Message-ID: 2e0add770808250106h2261c300gd7d6e04ab2cb8ddf () mail ! gmail ! com
[Download RAW message or body]

>
> SVN commit 852050 by mlaurent:
> +    } else if( (args->count() > 0) && (args->isSet("height")) &&
> (args->isSet("width")) ){
>

The style here is out of whack with the surrounding code. Also, the count()
check is unnecessary given the other two conditions. Compare the condition
above with:

args->isSet("height") && args->isSet("width")

--
Jason Stubbs

[Attachment #3 (text/html)]

<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; \
padding-left: 1ex;">SVN commit 852050 by mlaurent:<br> + &nbsp; &nbsp;} else if( \
(args-&gt;count() &gt; 0) &amp;&amp; (args-&gt;isSet(&quot;height&quot;)) &amp;&amp; \
(args-&gt;isSet(&quot;width&quot;)) ){<br>  </blockquote></div><br>The style here is \
out of whack with the surrounding code. Also, the count() check is unnecessary given \
the other two conditions. Compare the condition above with:<br>
<br>
args-&gt;isSet(&quot;height&quot;) &amp;&amp; args-&gt;isSet(&quot;width&quot;)<br>
<br>
--<br>
Jason Stubbs<br>
<br>
</div>



[prev in list] [next in list] [prev in thread] [next in thread]