[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/akregator/src
From:       Frank Osterfeld <frank.osterfeld () kdemail ! net>
Date:       2008-08-22 18:15:36
Message-ID: 1219428936.865299.13723.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 851000 by osterfeld:

Avoid empty tabs: there is only one createNewWindow signal since KDE4, with part \
defaulting to 0. Thus we shouldn't connect twice to createNewWindow.

 M  +1 -13     browserframe.cpp  
 M  +0 -1      browserframe.h  
 M  +0 -2      browserframe_p.cpp  


--- trunk/KDE/kdepim/akregator/src/browserframe.cpp #850999:851000
@@ -96,7 +96,7 @@
 
 namespace {
 
-OpenUrlRequest requestFromSender( QObject* sender, int id )
+static OpenUrlRequest requestFromSender( QObject* sender, int id )
 {
     QAction* const action = qobject_cast<QAction*>( sender );
     assert( action );
@@ -205,18 +205,6 @@
     emit signalOpenUrlRequest(req);
 }
 
-void BrowserFrame::slotCreateNewWindow(const KUrl& url, const OpenUrlArguments& \
                args, const BrowserArguments& browserArgs)
-{
-    OpenUrlRequest req;
-    req.setFrameId(id());
-    req.setUrl(url);
-    req.setArgs(args);
-    req.setBrowserArgs(browserArgs);
-    req.setOptions(OpenUrlRequest::NewTab);
-
-    emit signalOpenUrlRequest(req);
-}
-
 void BrowserFrame::slotCreateNewWindow(const KUrl& url,
                                        const OpenUrlArguments& args,
                                        const BrowserArguments& browserArgs,
--- trunk/KDE/kdepim/akregator/src/browserframe.h #850999:851000
@@ -77,7 +77,6 @@
     private slots:
 
         void slotOpenUrlRequestDelayed(const KUrl&, const KParts::OpenUrlArguments&, \
                const KParts::BrowserArguments&);
-        void slotCreateNewWindow(const KUrl& url, const KParts::OpenUrlArguments& \
args, const KParts::BrowserArguments& browserArgs);  void slotCreateNewWindow(const \
KUrl& url,  const KParts::OpenUrlArguments& args,
                                  const KParts::BrowserArguments& browserArgs,
--- trunk/KDE/kdepim/akregator/src/browserframe_p.cpp #850999:851000
@@ -251,8 +251,6 @@
                     q, SLOT(slotSetLocationBarUrl(QString)) );
             connect(ext, SIGNAL(setIconUrl(KUrl)),
                     q, SLOT(slotSetIconUrl(KUrl)) );
-            connect(ext, SIGNAL(createNewWindow( KUrl, KParts::OpenUrlArguments, \
                KParts::BrowserArguments ) ),
-                    q, SLOT(slotCreateNewWindow( KUrl, KParts::OpenUrlArguments, \
KParts::BrowserArguments ) ) );  connect(ext, SIGNAL( createNewWindow( KUrl,
                     KParts::OpenUrlArguments,
                     KParts::BrowserArguments,


[prev in list] [next in list] [prev in thread] [next in thread]