--nextPart2204848.pIqQ0T3AxZ
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Wednesday 20 August 2008 23:50:29 Helio Chissini de Castro wrote:
> - Qtfied phonon-xine.

Hi Helio,

reviewing that patch, here's what's still left to do:

o replace qDebug() calls with a custom function that allows to switch debug=
=20
messages off via an environment variable (since we don't have kdebugdialog=
=20
available anymore)

o qFatal is not the correct replacement for kError

o and qWarning is not the correct replacement for kFatal

o QT_(BEGIN|END)_NAMESPACE is not meant for code outside of Qt

o please look for a way to make the KDE platform plugin provide the actual=
=20
QIcon for the cases where the KIcon objects were replaced with QString

o you simply deleted all config settings? Please get them back using QSetti=
ngs=20
and provide a migration script

o you removed some i18n calls, not replacing it with one of Qt's translate=
=20
functions, please use QObject::tr or the global translate function instead =
of=20
i18n

o you removed some comments (e.g.
=2D  "execution of all clients, and low latency operation.</p></html>"),
=2D  /*icon name */"audio-backend-jack", outputPlugins[i]);
+  "execution of all clients, and low latency operation.</p></html>","audio-
backend-jack", outputPlugins[i] );
). Please put the comments back.

o And please restore the kdelibs coding style where you changed it.

o why did you comment out this?
=2Dextern const char Error__off_t_needs_to_have_64_bits[sizeof(off_t) =3D=
=3D 8 ? 1 :=20
=2D1];
+//extern const char Error__off_t_needs_to_have_64_bits[sizeof(off_t) =3D=
=3D 8 ? 1=20
: -1];

I guess because you made off_t 32 bit (you're working on a 32 bit system?).=
=20
The check was there for a reason.

o in volumefadereffet.cpp you unnecessarily removed a kError line

o you removed all i18n calls in volumefader_plugin.c, even I18N_NOOP should=
 be=20
possible with Qt's system

o you broke loading the volume fader plugin by removing a K from KVolumeFad=
er

o you reverted one of my last commits which made it cache the memcpy benchm=
ark=20
results (now it'll benchmark all its memcpy methods on startup again)

o this can't work: tr( QString( "Cannot open media data at '<i>%1</i>'" ).a=
rg(=20
m_mrl.constData()))

o you probably broke some URLs:
=2D    gaplessSwitchTo(url.url().toUtf8());
+    gaplessSwitchTo(url.toString().toUtf8());
use QUrl::toEncoded instead



=2D-=20
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de


--nextPart2204848.pIqQ0T3AxZ
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIrTcMyg4WnCj6OIoRAhW/AJwKanHw/b6snyhCg8u4ybjGDSZnPQCfZa3G
3YmA3/ynsXcLqr8QVQcFXqo=
=HKip
-----END PGP SIGNATURE-----

--nextPart2204848.pIqQ0T3AxZ--