[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.1/kdeplasma-addons/applets/libplasmaappletdialog
From:       Bram Schoenmakers <bramschoenmakers () kde ! nl>
Date:       2008-08-16 10:44:36
Message-ID: 1218883476.390999.17458.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 847792 by bram:

Fix Konsole and Konqueror profile applets when residing on the desktop:

o Hide the icon. Maybe someone can do something creative with it, but clicking on
  it crashed Plasma if the applet was on the desktop. Hence the extra safeguard
  in slotOpenDialog().
o Set minimum size to 100x100 when the applet is on the desktop.

 M  +7 -1      plasmaappletdialog.cpp  


--- branches/KDE/4.1/kdeplasma-addons/applets/libplasmaappletdialog/plasmaappletdialog.cpp #847791:847792
@@ -95,8 +95,9 @@
                 m_proxy->show();
             }
 
+            m_icon->setVisible(false);
             m_layout->addItem(m_proxy);
-            setMinimumSize( m_minimumSize.width(), m_minimumSize.height());
+            setMinimumSize( 100, 100);
             break;
         case Plasma::Horizontal:
         case Plasma::Vertical:
@@ -128,6 +129,11 @@
 
 void PlasmaAppletDialog::slotOpenDialog()
 {
+    if (!m_dialog) {
+      // applet is on desktop
+      return;
+    }
+
     if (m_dialog->isVisible()) {
         m_dialog->hide();
     } else {
[prev in list] [next in list] [prev in thread] [next in thread]