From kde-commits Mon Aug 11 08:09:02 2008 From: Matthias Kretz Date: Mon, 11 Aug 2008 08:09:02 +0000 To: kde-commits Subject: KDE/kdebase/runtime/phonon/xine Message-Id: <1218442142.716582.6739.nullmailer () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=121844215517789 SVN commit 845068 by mkretz: use MySharedDataPointer here as well to simplify the code M +3 -8 xinestream.cpp M +2 -1 xinestream.h --- trunk/KDE/kdebase/runtime/phonon/xine/xinestream.cpp #845067:845068 @@ -148,7 +148,6 @@ m_nullAudioPort(0), m_nullVideoPort(0), m_state(Phonon::LoadingState), - m_byteStream(0), m_prefinishMarkTimer(0), m_errorType(Phonon::NoError), m_lastSeekCommand(0), @@ -1805,18 +1804,14 @@ if (newMrl != m_mrl) { if (m_mrl.startsWith("kbytestream:/")) { Q_ASSERT(m_byteStream); - Q_ASSERT(ByteStream::fromMrl(m_mrl) == m_byteStream); - if (!m_byteStream->ref.deref()) { - m_byteStream->deleteLater(); - } - m_byteStream = 0; + Q_ASSERT(ByteStream::fromMrl(m_mrl) == m_byteStream.data()); + m_byteStream.reset(); } m_mrl = newMrl; if (m_mrl.startsWith("kbytestream:/")) { - Q_ASSERT(m_byteStream == 0); + Q_ASSERT(m_byteStream.data() == 0); m_byteStream = ByteStream::fromMrl(m_mrl); Q_ASSERT(m_byteStream); - m_byteStream->ref.ref(); } } } --- trunk/KDE/kdebase/runtime/phonon/xine/xinestream.h #845067:845068 @@ -38,6 +38,7 @@ #include #include #include "xineengine.h" +#include "myshareddatapointer.h" class KUrl; @@ -222,7 +223,7 @@ QWaitCondition m_waitingForRewire; QMultiMap m_metaDataMap; QByteArray m_mrl; - ByteStream *m_byteStream; + MySharedDataPointer m_byteStream; QTimer *m_prefinishMarkTimer; struct timeval m_lastTimeUpdate;