[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/plasma/applets
From:       Sebastian =?utf-8?q?K=C3=BCgler?= <sebas () kde ! org>
Date:       2008-08-10 13:10:50
Message-ID: 200808101510.50972.sebas () kde ! org
[Download RAW message or body]


Teemu,

On Thursday 07 August 2008 18:49:05 Teemu Rytilahti wrote:
> SVN commit 843702 by rytilahti:
>
> Add support to digital-clock for changing the timezone by using a mouse
> wheel.

Can you please revert this patch, and put it on reviewboard for comment? I 
consider it not-so-nice behaviour to just commit such change in behaviour to 
other people's code. We usually run those through reviewboard and have others 
have a look at it, and comment it.
Besides that, I don't really like this hidden behaviour you're introducing, 
maybe we can find a better way of making it easier to switch or display 
timezones. The direct issue I have is that one might change the timezone 
accidentally, and then be to late for something, or get confused. A good start 
would be for example to display the selected timezones in the tooltip.

Thanks,
-- 
sebas

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]