[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.1/kdelibs/khtml
From:       Maks Orlovich <maksim () kde ! org>
Date:       2008-07-28 15:31:00
Message-ID: 1217259060.503097.2436.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 838712 by orlovich:

Don't crash on navigating away when a suppressed popup 
comes from a child frame which in turn got navigated away,
deleting the part the m_suppressedPopupOriginParts list is referring to.

BUG:167514


 M  +2 -1      khtmlpart_p.h  


--- branches/KDE/4.1/kdelibs/khtml/khtmlpart_p.h #838711:838712
@@ -269,7 +269,8 @@
   KUrlLabel* m_statusBarUALabel;
   KUrlLabel* m_statusBarJSErrorLabel;
   KUrlLabel* m_statusBarPopupLabel;
-  QList<KHTMLPart *> m_suppressedPopupOriginParts;
+  QList<QPointer<KHTMLPart> > m_suppressedPopupOriginParts; // We need to guard these in case the origin
+                                                            // is a child part.
   int m_openableSuppressedPopups;
   DOM::DocumentImpl *m_doc;
   KEncodingDetector::AutoDetectScript m_autoDetectLanguage;
[prev in list] [next in list] [prev in thread] [next in thread]