[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/kcontrol/standard_actions
From:       Michael Jansen <kde () michael-jansen ! biz>
Date:       2008-07-25 23:15:52
Message-ID: 1217027752.469909.8304.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 837893 by mjansen:

Show an information dialog when the user changed standard shortcuts.

I'm not really confident with the text and position of this message (in the
workflow). Better ideas anyone?

CCMAIL: kde-core-devel@kde.org


 M  +10 -1     standard_actions_module.cpp  


--- trunk/KDE/kdebase/workspace/kcontrol/standard_actions/standard_actions_module.cpp #837892:837893
@@ -26,6 +26,8 @@
 #include <KPluginFactory>
 #include <KShortcutsEditor>
 #include <KStandardAction>
+#include <KMessageBox>
+#include <KLocale>
 
 K_PLUGIN_FACTORY(StandardActionsModuleFactory, registerPlugin<StandardActionsModule>();)
 K_EXPORT_PLUGIN(StandardActionsModuleFactory("kcmstandard_actions"))
@@ -114,7 +116,6 @@
 
 void StandardActionsModule::save()
     {
-    // TODO Check what this call does
     m_editor->commit();
 
     Q_FOREACH(QAction* action, m_actionCollection->actions())
@@ -129,6 +130,14 @@
     KGlobal::config()->sync();
     KConfigGroup cg(KGlobal::config(), "Shortcuts");
     cg.sync();
+
+    QString title = i18n("Standard Actions successfully saved");
+    QString message = i18n(
+        "The changes have been saved. Please consider:"
+        "<ul><li>Applications need to be restarted to see the changes.</li>"
+        "    <li>This change could introduce shortcut conflicts in some applications.<li>"
+        "</ul" );
+    KMessageBox::information(this, message, title, i18n("shortcuts_saved_info"));
     }
 
 #include "standard_actions_module.moc"
[prev in list] [next in list] [prev in thread] [next in thread]