[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.1/kdeplasma-addons/applets/frame
From:       Laurent Montel <montel () kde ! org>
Date:       2008-07-22 7:43:32
Message-ID: 1216712612.252302.18316.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 836415 by mlaurent:

Backport:
Fix big mem leak


 M  +3 -3      frame.cpp  


--- branches/KDE/4.1/kdeplasma-addons/applets/frame/frame.cpp #836414:836415
@@ -182,9 +182,9 @@
     
     KService::List services = KServiceTypeTrader::self()->query( \
"PlasmaPoTD/Plugin");  foreach (const KService::Ptr &service, services) {
-	const QString *service_name = new QString ( service->name() );
-	const QVariant *service_identifier = new QVariant ( service->property( \
                "X-KDE-PlasmaPoTDProvider-Identifier", QVariant::String ).toString() \
                );
-	m_configDialog->ui.potdComboBox->insertItem( \
m_configDialog->ui.potdComboBox->count(), *service_name, *service_identifier ); \
+	const QString service_name( service->name() ); +	const QVariant service_identifier( \
service->property( "X-KDE-PlasmaPoTDProvider-Identifier", QVariant::String \
).toString() ); +	m_configDialog->ui.potdComboBox->insertItem( \
m_configDialog->ui.potdComboBox->count(), service_name, service_identifier );  }
 
     parent->setButtons(  KDialog::Ok | KDialog::Cancel | KDialog::Apply);


[prev in list] [next in list] [prev in thread] [next in thread]