[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/runtime/phonon/xine
From:       Matthias Kretz <kretz () kde ! org>
Date:       2008-07-18 19:11:35
Message-ID: 1216408295.827929.22297.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 834384 by mkretz:

pullBuffer modifies m_buffersize, so m_currentPosition was not adjusted correctly

 M  +3 -2      bytestream.cpp  


--- trunk/KDE/kdebase/runtime/phonon/xine/bytestream.cpp #834383:834384
@@ -223,8 +223,9 @@
     Q_ASSERT(m_eod);
     if (m_buffersize > 0) {
         PXINE_VDEBUG << "calling pullBuffer with m_buffersize = " << m_buffersize;
-        pullBuffer(static_cast<char *>(buf), m_buffersize);
-        m_currentPosition += m_buffersize;
+        const int len = m_buffersize;
+        pullBuffer(static_cast<char *>(buf), len);
+        m_currentPosition += len;
         PXINE_DEBUG << "returning less data than requested, the stream is at its end";
         //kDebug(610) << "UNLOCKING m_mutex: ";
         return m_buffersize;
[prev in list] [next in list] [prev in thread] [next in thread]