[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/krunner/lock
From:       Chani Armitage <chanika () gmail ! com>
Date:       2008-07-18 17:08:57
Message-ID: 1216400937.479451.16444.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 834331 by chani:

Revert "we don't seem to need that fakeFocusIn, but I'm still uneasy about it"
turns out it's needed for qactions. oops.
This reverts commit 3b649ce8d498519e5094be128b45c34edcd724b0.


 M  +4 -3      lockprocess.cc  


--- trunk/KDE/kdebase/workspace/krunner/lock/lockprocess.cc #834330:834331
@@ -1125,9 +1125,10 @@
         mDialogs.remove( pos );
     if( mDialogs.isEmpty() ) {
         //blank pointer + plasma = confused user
-        //FIXME plasma doesn't seem to need fakeFocusIn, but
-        //it also never seems to get a focus*out*
-        if (mForeignInputWindows.isEmpty()) {
+        //FIXME do we really need to fakefocusin plasma?
+        if (mPlasmaView) {
+            fakeFocusIn(mPlasmaView);
+        } else {
             XChangeActivePointerGrab( QX11Info::display(), GRABEVENTS,
                     QCursor(Qt::BlankCursor).handle(), CurrentTime);
         }
[prev in list] [next in list] [prev in thread] [next in thread]