[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/runtime
From:       Dirk Mueller <mueller () kde ! org>
Date:       2008-07-02 12:30:45
Message-ID: 200807021430.46926.mueller () kde ! org
[Download RAW message or body]

On Wednesday 02 July 2008, David Faure wrote:

> Move up the definition of _FILE_OFFSET_BITS so that it's also available for
> kio_trash, otherwise files bigger than 2GB cannot be trashed on 32 bit
> systems!

sure they can, if you use kde_file.h operations instead of plain ::open (like 
the code does now). 

> I don't think it hurts to define it for all

The definition might break binary compatibility (off_t is suddenly 64bit instead 
of 32bit). Also, if you use the wrong flag for compiling against a 3rd party 
library, your app will crash or corrupt its stack (like it is popular with 
phonon/xine).

Greetings,
Dirk

[prev in list] [next in list] [prev in thread] [next in thread]