[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/kdepim/enterprise4/kdelibs-4.0.83/kded
From:       David Faure <dfaure () kdab ! net>
Date:       2008-06-24 18:08:23
Message-ID: 200806242008.25692.dfaure () kdab ! net
[Download RAW message or body]

On Tuesday 24 June 2008, Jaroslaw Staniek wrote:
> David Faure said the following, On 2008-06-24 16:20:
> > On Tuesday 24 June 2008, Jaroslaw Staniek wrote:
> >> SVN commit 823974 by staniek:
> >>
> >> compile qt4_add_dbus_interfaces
> >>
> >>
> >>  M  +3 -3      CMakeLists.txt  
> >>
> >>
> >> --- branches/kdepim/enterprise4/kdelibs-4.0.83/kded/CMakeLists.txt #823973:823974
> >> @@ -6,9 +6,7 @@
> >>  
> >>  ########### next target ###############
> >>  
> >> -set(kded_KDEINIT_SRCS kded.cpp kdedadaptor.cpp
> >> -    ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kded.xml # just so that it gets generated
> >> -)
> >> +set(kded_KDEINIT_SRCS kded.cpp kdedadaptor.cpp)
> >>  
> >>  
> >>  kde4_add_kdeinit_executable(kded4  ${kded_KDEINIT_SRCS})
> >> @@ -22,6 +20,8 @@
> >>  
> >>  
> >>  qt4_generate_dbus_interface( kdedadaptor.h org.kde.kded.xml )
> >> +qt4_add_dbus_interfaces( kded_KDEINIT_SRCS org.kde.kded.xml )
> > 
> > Why? There is nothing in kded that talks to itself (obviously!),
> > so there is no need to generate the client-side interface here. I don't understand
> > this commit - it sounds like a workaround for a cmake problem?
> 
> Exactly, it was request from someone using cmake 2.4.x. If you don't like it, 
> I'll revert this stupidity.

Well, our code should work with cmake-2.4.x for now - and I thought it did. Surely
more people would complain if it didn't, no? This must be a Windows-only problem I gues?


-- 
David Faure, faure@kde.org, dfaure@kdab.net
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]